Adding missing min/max value for column stats during segment creation#8452
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Mar 31, 2022
Merged
Conversation
Jackie-Jiang
approved these changes
Mar 31, 2022
Contributor
|
Ideally we should add a test to catch the missing fields |
richardstartin
approved these changes
Mar 31, 2022
Contributor
Author
These are newly added stats, which were missed from the previous PR: #8442 |
Codecov Report
@@ Coverage Diff @@
## master #8452 +/- ##
============================================
+ Coverage 64.21% 70.71% +6.50%
+ Complexity 4282 4281 -1
============================================
Files 1618 1663 +45
Lines 85376 87285 +1909
Branches 13004 13208 +204
============================================
+ Hits 54820 61720 +6900
+ Misses 26576 21275 -5301
- Partials 3980 4290 +310
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding missed stats from the previous PR: #8442
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation