Skip to content

Adding missing min/max value for column stats during segment creation#8452

Merged
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:fixing_index_creator_min_max_stats
Mar 31, 2022
Merged

Adding missing min/max value for column stats during segment creation#8452
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:fixing_index_creator_min_max_stats

Conversation

@xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Mar 31, 2022

Description

Adding missed stats from the previous PR: #8442

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@xiangfu0 xiangfu0 changed the title Adding min/max value for column stats during segment creation Adding missing min/max value for column stats during segment creation Mar 31, 2022
@Jackie-Jiang
Copy link
Contributor

Ideally we should add a test to catch the missing fields

@xiangfu0
Copy link
Contributor Author

Ideally we should add a test to catch the missing fields

These are newly added stats, which were missed from the previous PR: #8442

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #8452 (6047d95) into master (91c9ce4) will increase coverage by 6.50%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8452      +/-   ##
============================================
+ Coverage     64.21%   70.71%   +6.50%     
+ Complexity     4282     4281       -1     
============================================
  Files          1618     1663      +45     
  Lines         85376    87285    +1909     
  Branches      13004    13208     +204     
============================================
+ Hits          54820    61720    +6900     
+ Misses        26576    21275    -5301     
- Partials       3980     4290     +310     
Flag Coverage Δ
integration1 27.20% <0.00%> (?)
integration2 26.03% <0.00%> (?)
unittests1 67.04% <100.00%> (-0.01%) ⬇️
unittests2 14.16% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ment/creator/impl/SegmentColumnarIndexCreator.java 86.57% <100.00%> (+0.07%) ⬆️
.../helix/core/minion/MinionInstancesCleanupTask.java 77.27% <0.00%> (-4.55%) ⬇️
.../impl/dictionary/BaseOffHeapMutableDictionary.java 81.33% <0.00%> (-3.34%) ⬇️
...t/plugin/inputformat/json/JSONRecordExtractor.java 0.00% <0.00%> (ø)
...pache/pinot/plugin/metrics/yammer/YammerGauge.java 66.66% <0.00%> (ø)
...ot/server/api/resources/PinotServerAppConfigs.java 0.00% <0.00%> (ø)
...t/server/starter/ServerQueriesDisabledTracker.java 86.36% <0.00%> (ø)
.../pinot/server/api/resources/TableSizeResource.java 80.00% <0.00%> (ø)
...ache/pinot/server/api/resources/DebugResource.java 0.00% <0.00%> (ø)
...che/pinot/server/api/resources/TablesResource.java 43.97% <0.00%> (ø)
... and 367 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c9ce4...6047d95. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 86958b6 into apache:master Mar 31, 2022
@xiangfu0 xiangfu0 deleted the fixing_index_creator_min_max_stats branch March 31, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants