Error message if the dimension table in memory hasn't been populated#8505
Merged
richardstartin merged 2 commits intoapache:masterfrom Apr 11, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a scenario where the Pinot Server previously downloaded the segment for a dimension table and is then restarted, which means the
addSegmentflow doesn't get called.This means that the in-memory
DimensionTableis empty and thelookupJoinfunction always returns null values. I'm not sure what the proper solution for solving that problem is - I guess the user could delete the segment and re-download it?But this PR doesn't address that - instead, it throws an exception if you try to do a lookup join when the in-memory dimensions table is empty.