throw when integer overflow occurs#8710
Merged
snleee merged 1 commit intoapache:masterfrom May 16, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8710 +/- ##
=============================================
- Coverage 69.67% 14.31% -55.36%
+ Complexity 4571 168 -4403
=============================================
Files 1722 1677 -45
Lines 89862 87930 -1932
Branches 13335 13125 -210
=============================================
- Hits 62610 12589 -50021
- Misses 22920 74410 +51490
+ Partials 4332 931 -3401
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snleee
approved these changes
May 16, 2022
Contributor
snleee
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the quick fix on this :)
Contributor
|
LGTM. Thanks for fixing this! |
Member
Author
|
Just for posterity, Pinot raw forward indexes have always had this limitation; it wasn’t a regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8701 by throwing early. The workaround is to start using V3 or V4.