Change DateTimeFormatSpec delimiter #8727
Closed
stym06 wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
walterddr
reviewed
May 18, 2022
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
thanks for the contribution @stym06 . this looks super great.
please take a look at these tips to get CI green
- for the linter errors: you can use
.github/workflows/scripts/.pinot_linter.shto run it locally and fix the issues. - you will encounter test failure because of this change when you run
mvn test. please let me know if any of these test issues are not clear or not easy to resolve.
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
The new format support looks good, but we want to keep it backward compatible so that existing schema still work. Essentially we need to support both format for now, and then slowly deprecate the old format. In the test, we should also test both the old and new format to ensure the change is backward compatible
Contributor
Author
|
Got it @Jackie-Jiang I will make the required changes |
Contributor
Author
|
Created another PR #8779 with backward compatibility as there were multiple merge conflicts and stuff in this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #8632 , this PR is for changing the format in the DateTimeFieldSpec.