-
Notifications
You must be signed in to change notification settings - Fork 1.4k
improve date time field validation #8792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve date time field validation #8792
Conversation
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only minor comments
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpec.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpec.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/test/java/org/apache/pinot/spi/data/DateTimeFormatSpecTest.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/test/java/org/apache/pinot/spi/data/DateTimeFormatSpecTest.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/test/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpecTest.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpec.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #8792 +/- ##
============================================
+ Coverage 62.86% 69.64% +6.78%
- Complexity 4601 4621 +20
============================================
Files 1690 1736 +46
Lines 89212 91217 +2005
Branches 13411 13633 +222
============================================
+ Hits 56082 63530 +7448
+ Misses 29079 23270 -5809
- Partials 4051 4417 +366
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
improve date time field validation to discover schema issues early