Skip to content

Conversation

@zhtaoxiang
Copy link
Contributor

improve date time field validation to discover schema issues early

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor comments

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #8792 (d2d8e18) into master (c4549e2) will increase coverage by 6.78%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8792      +/-   ##
============================================
+ Coverage     62.86%   69.64%   +6.78%     
- Complexity     4601     4621      +20     
============================================
  Files          1690     1736      +46     
  Lines         89212    91217    +2005     
  Branches      13411    13633     +222     
============================================
+ Hits          56082    63530    +7448     
+ Misses        29079    23270    -5809     
- Partials       4051     4417     +366     
Flag Coverage Δ
integration1 26.96% <0.00%> (?)
integration2 25.41% <0.00%> (?)
unittests1 66.20% <100.00%> (+0.05%) ⬆️
unittests2 14.21% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ache/pinot/spi/data/DateTimeFormatPatternSpec.java 79.59% <100.00%> (+7.36%) ⬆️
.../org/apache/pinot/spi/data/DateTimeFormatSpec.java 77.14% <100.00%> (+0.33%) ⬆️
...inot/plugin/inputformat/json/JSONRecordReader.java 0.00% <0.00%> (ø)
...ot/plugin/metrics/yammer/YammerMetricsFactory.java 100.00% <0.00%> (ø)
...che/pinot/server/api/resources/TablesResource.java 43.97% <0.00%> (ø)
...ugin/inputformat/csv/CSVRecordExtractorConfig.java 0.00% <0.00%> (ø)
.../pinot/server/starter/helix/BaseServerStarter.java 59.94% <0.00%> (ø)
.../java/org/apache/pinot/server/conf/ServerConf.java 80.76% <0.00%> (ø)
...t/plugin/metrics/yammer/YammerMetricsRegistry.java 60.00% <0.00%> (ø)
...pache/pinot/server/starter/helix/SegmentLocks.java 100.00% <0.00%> (ø)
... and 397 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4549e2...d2d8e18. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit 8bfec60 into apache:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants