Skip to content

Fix runtime failure in RealtimeQuickStartWithMinion#8871

Closed
KKcorps wants to merge 1 commit intoapache:masterfrom
KKcorps:quickstart_patch_minion
Closed

Fix runtime failure in RealtimeQuickStartWithMinion#8871
KKcorps wants to merge 1 commit intoapache:masterfrom
KKcorps:quickstart_patch_minion

Conversation

@KKcorps
Copy link
Contributor

@KKcorps KKcorps commented Jun 9, 2022

The map in superclass is immutable. Hence the it fails at runtime.

@KKcorps KKcorps added the bugfix label Jun 9, 2022
@KKcorps KKcorps requested a review from xiangfu0 June 9, 2022 15:40
@codecov-commenter
Copy link

Codecov Report

Merging #8871 (c407502) into master (e8f9d88) will decrease coverage by 0.05%.
The diff coverage is 68.10%.

❗ Current head c407502 differs from pull request most recent head 736e26d. Consider uploading reports for the commit 736e26d to get more accurate results

@@             Coverage Diff              @@
##             master    #8871      +/-   ##
============================================
- Coverage     68.56%   68.51%   -0.06%     
- Complexity     4640     4977     +337     
============================================
  Files          1741     1804      +63     
  Lines         91475    93883    +2408     
  Branches      13674    13981     +307     
============================================
+ Hits          62724    64325    +1601     
- Misses        24363    25056     +693     
- Partials       4388     4502     +114     
Flag Coverage Δ
integration1 26.30% <1.08%> (-0.77%) ⬇️
unittests1 66.43% <72.23%> (+0.21%) ⬆️
unittests2 15.45% <61.50%> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...roker/requesthandler/BaseBrokerRequestHandler.java 68.45% <ø> (ø)
...roker/requesthandler/GrpcBrokerRequestHandler.java 0.00% <0.00%> (ø)
...requesthandler/MultiStageBrokerRequestHandler.java 0.00% <0.00%> (ø)
...ctionaryBasedSingleColumnDistinctOnlyExecutor.java 0.00% <0.00%> (ø)
...e/pinot/plugin/stream/kinesis/KinesisConsumer.java 33.33% <0.00%> (-1.33%) ⬇️
...segment/creator/impl/SegmentDictionaryCreator.java 91.11% <0.00%> (-1.55%) ⬇️
...gment/index/column/IntermediateIndexContainer.java 81.57% <ø> (ø)
...al/segment/index/datasource/MutableDataSource.java 87.50% <ø> (ø)
...ache/pinot/segment/local/utils/IngestionUtils.java 28.07% <0.00%> (-0.17%) ⬇️
.../pinot/server/starter/helix/BaseServerStarter.java 56.72% <0.00%> (-0.76%) ⬇️
... and 149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f9d88...736e26d. Read the comment docs.

@npawar
Copy link
Contributor

npawar commented Jun 9, 2022

duplicate of #8858

@KKcorps KKcorps closed this Jun 12, 2022
@KKcorps KKcorps deleted the quickstart_patch_minion branch June 12, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants