Skip to content

Extract Pinot Broker Endpoints with interfaces#8876

Draft
dongxiaoman wants to merge 2 commits intoapache:masterfrom
dongxiaoman:xd-openapi-v2
Draft

Extract Pinot Broker Endpoints with interfaces#8876
dongxiaoman wants to merge 2 commits intoapache:masterfrom
dongxiaoman:xd-openapi-v2

Conversation

@dongxiaoman
Copy link
Copy Markdown
Contributor

Description

We extract the endpoints of Pinot Broker into public interfaces so it will have full compatibility in future.
It is a plain refactor of putting all endpoints into interface.

It is side to side with #8852

Tests done

QuickStart and open UI

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 11, 2022

Codecov Report

Merging #8876 (0c31c84) into master (754e807) will decrease coverage by 1.55%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##             master    #8876      +/-   ##
============================================
- Coverage     69.65%   68.10%   -1.56%     
- Complexity     4679     4680       +1     
============================================
  Files          1806     1806              
  Lines         94201    94201              
  Branches      14050    14050              
============================================
- Hits          65620    64157    -1463     
- Misses        24021    25548    +1527     
+ Partials       4560     4496      -64     
Flag Coverage Δ
integration1 ?
integration2 24.76% <40.00%> (-0.08%) ⬇️
unittests1 66.37% <ø> (-0.01%) ⬇️
unittests2 15.42% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ot/broker/api/resources/PinotBrokerAppConfigs.java 0.00% <0.00%> (ø)
...t/broker/api/resources/PinotBrokerHealthCheck.java 0.00% <0.00%> (ø)
...pinot/broker/api/resources/PinotBrokerRouting.java 0.00% <0.00%> (ø)
...e/pinot/broker/api/resources/PinotBrokerDebug.java 85.71% <100.00%> (ø)
...pinot/broker/api/resources/PinotClientRequest.java 50.94% <100.00%> (-7.55%) ⬇️
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) ⬇️
...nverttorawindex/ConvertToRawIndexTaskExecutor.java 0.00% <0.00%> (-100.00%) ⬇️
...e/pinot/common/minion/MergeRollupTaskMetadata.java 0.00% <0.00%> (-94.74%) ⬇️
...plugin/segmentuploader/SegmentUploaderDefault.java 0.00% <0.00%> (-87.10%) ⬇️
.../transform/function/MapValueTransformFunction.java 0.00% <0.00%> (-85.30%) ⬇️
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754e807...0c31c84. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants