Skip to content

fix integration test#8915

Merged
walterddr merged 1 commit intoapache:masterfrom
walterddr:fix_grpc_itcase
Jun 18, 2022
Merged

fix integration test#8915
walterddr merged 1 commit intoapache:masterfrom
walterddr:fix_grpc_itcase

Conversation

@walterddr
Copy link
Copy Markdown
Contributor

@walterddr walterddr commented Jun 17, 2022

Looks like @AfterTest was not added to GRPC integration tests.

related to #8767 #8684

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #8915 (7331965) into master (7024a6d) will decrease coverage by 6.70%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8915      +/-   ##
============================================
- Coverage     69.72%   63.02%   -6.71%     
+ Complexity     4856     4837      -19     
============================================
  Files          1809     1762      -47     
  Lines         94331    92270    -2061     
  Branches      14069    13837     -232     
============================================
- Hits          65777    58152    -7625     
- Misses        23974    29929    +5955     
+ Partials       4580     4189     -391     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 66.39% <ø> (ø)
unittests2 14.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pinot/core/routing/RoutingTable.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/common/config/NettyConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...apache/pinot/common/helix/ExtraInstanceConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...ache/pinot/server/access/AccessControlFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/TableDeletionMessage.java 0.00% <0.00%> (-100.00%) ⬇️
... and 406 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7024a6d...7331965. Read the comment docs.

@walterddr walterddr marked this pull request as ready for review June 17, 2022 19:35
@walterddr walterddr merged commit dd1894d into apache:master Jun 18, 2022
@walterddr walterddr deleted the fix_grpc_itcase branch December 6, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants