Use binary search for index creation dictionary lookup#8924
Use binary search for index creation dictionary lookup#8924siddharthteotia merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8924 +/- ##
=============================================
- Coverage 68.09% 26.65% -41.45%
+ Complexity 4711 1 -4710
=============================================
Files 1813 1801 -12
Lines 94522 94159 -363
Branches 14111 14073 -38
=============================================
- Hits 64363 25096 -39267
- Misses 25642 66660 +41018
+ Partials 4517 2403 -2114
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@siddharthteotia Sorry didn't call out in the PR description (more context is in #8846), but was planning to run some perf test using this branch. This change can potentially increase the segment creation time, but per the benchmark I performed locally, the overhead should be quite small. If you find the index creation time is significantly longer, we can revert this one. |
|
Why are we doing this? Reduce memory usage at cost of performance? |
|
@kishoreg This is only during the segment creation. Ideally we want to bring everything to off-heap |
Follow up on #8846