Skip to content

avoid redundant record transforms#8935

Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom
klsince:remove_redundant_transforms
Jun 21, 2022
Merged

avoid redundant record transforms#8935
Jackie-Jiang merged 2 commits intoapache:masterfrom
klsince:remove_redundant_transforms

Conversation

@klsince
Copy link
Contributor

@klsince klsince commented Jun 20, 2022

Avoid redundant record transforms, as those are already done during SegmentProcessorFramework.map() phase.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #8935 (2848dd0) into master (09fcdd5) will decrease coverage by 40.77%.
The diff coverage is 7.69%.

@@              Coverage Diff              @@
##             master    #8935       +/-   ##
=============================================
- Coverage     69.69%   28.92%   -40.78%     
+ Complexity     4630       47     -4583     
=============================================
  Files          1813     1801       -12     
  Lines         94521    94174      -347     
  Branches      14116    14079       -37     
=============================================
- Hits          65879    27237    -38642     
- Misses        24033    64397    +40364     
+ Partials       4609     2540     -2069     
Flag Coverage Δ
integration1 26.76% <7.69%> (+0.11%) ⬆️
integration2 24.89% <7.69%> (+0.02%) ⬆️
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/realtime/converter/RealtimeSegmentConverter.java 0.00% <0.00%> (-80.71%) ⬇️
...creator/RecordReaderSegmentCreationDataSource.java 0.00% <0.00%> (-75.87%) ⬇️
...gment/local/segment/creator/TransformPipeline.java 0.00% <0.00%> (-91.43%) ⬇️
...t/creator/impl/SegmentIndexCreationDriverImpl.java 0.00% <0.00%> (-84.62%) ⬇️
...rocessing/framework/SegmentProcessorFramework.java 89.85% <100.00%> (-8.70%) ⬇️
...in/java/org/apache/pinot/spi/utils/StringUtil.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1248 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09fcdd5...2848dd0. Read the comment docs.

@Jackie-Jiang Jackie-Jiang force-pushed the remove_redundant_transforms branch from 32279fc to 91177d0 Compare June 20, 2022 22:53
@Jackie-Jiang Jackie-Jiang force-pushed the remove_redundant_transforms branch from 91177d0 to 2848dd0 Compare June 20, 2022 22:58
@Jackie-Jiang Jackie-Jiang merged commit 9464359 into apache:master Jun 21, 2022
@klsince klsince deleted the remove_redundant_transforms branch June 21, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants