Skip to content

Support derived column of any type#8942

Merged
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:fix_derived_column
Jun 21, 2022
Merged

Support derived column of any type#8942
Jackie-Jiang merged 1 commit intoapache:masterfrom
Jackie-Jiang:fix_derived_column

Conversation

@Jackie-Jiang
Copy link
Contributor

  • Fix the issue of derived column expects function return type and cause cast exception. Leverage PinotDataType to convert the value
  • Add support for BIG_DECIMAL as default column or derived column

@codecov-commenter
Copy link

Codecov Report

Merging #8942 (4696479) into master (8474bae) will decrease coverage by 1.30%.
The diff coverage is 21.21%.

@@             Coverage Diff              @@
##             master    #8942      +/-   ##
============================================
- Coverage     69.73%   68.43%   -1.31%     
+ Complexity     4888     4696     -192     
============================================
  Files          1814     1814              
  Lines         94506    94542      +36     
  Branches      14117    14125       +8     
============================================
- Hits          65905    64697    -1208     
- Misses        23984    25286    +1302     
+ Partials       4617     4559      -58     
Flag Coverage Δ
integration1 26.65% <4.54%> (-0.06%) ⬇️
integration2 ?
unittests1 66.26% <21.21%> (-0.02%) ⬇️
unittests2 14.83% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...al/segment/index/readers/BigDecimalDictionary.java 80.00% <ø> (ø)
...main/java/org/apache/pinot/spi/data/FieldSpec.java 82.03% <ø> (ø)
...loader/defaultcolumn/BaseDefaultColumnHandler.java 58.24% <16.66%> (-4.92%) ⬇️
...a/org/apache/pinot/spi/data/DateTimeFieldSpec.java 89.74% <33.33%> (-4.86%) ⬇️
...java/org/apache/pinot/common/utils/DataSchema.java 69.00% <100.00%> (ø)
...apache/pinot/common/helix/ExtraInstanceConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...t/core/plan/StreamingInstanceResponsePlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ore/operator/streaming/StreamingResponseUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ager/realtime/PeerSchemeSplitSegmentCommitter.java 0.00% <0.00%> (-100.00%) ⬇️
...ator/streaming/StreamingSelectionOnlyOperator.java 0.00% <0.00%> (-90.00%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8474bae...4696479. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit 5a50954 into apache:master Jun 21, 2022
@Jackie-Jiang Jackie-Jiang deleted the fix_derived_column branch June 21, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants