adding explicit error on record reader#9024
Merged
siddharthteotia merged 2 commits intoapache:masterfrom Jul 7, 2022
Merged
Conversation
walterddr
commented
Jul 7, 2022
...al/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java
Outdated
Show resolved
Hide resolved
…al/indexsegment/mutable/MutableSegmentImpl.java
| reuse.putValue(column, value); | ||
| } | ||
| } catch (Exception e) { | ||
| _logger.error("error encountered when getting record for {} on indexContainer: {}", docId, entry.getKey()); |
Contributor
There was a problem hiding this comment.
(nit) suggest changing to
when getting record for docID {} for column {}
siddharthteotia
approved these changes
Jul 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #9024 +/- ##
============================================
- Coverage 70.08% 68.39% -1.70%
+ Complexity 4957 4733 -224
============================================
Files 1827 1827
Lines 96064 96097 +33
Branches 14356 14360 +4
============================================
- Hits 67327 65724 -1603
- Misses 24092 25798 +1706
+ Partials 4645 4575 -70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.