Skip to content

Conversation

@xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Jul 9, 2022

Adding AuthZkBasicQuickstart, which uses controller.admin.access.control.factory.class=org.apache.pinot.controller.api.access.ZkBasicAuthAccessControlFactory
and
pinot.broker.access.control.class=org.apache.pinot.broker.broker.ZkBasicAuthAccessControlFactory.

The default credential is admin/verysecret.

image

image

@xiangfu0 xiangfu0 requested review from Jackie-Jiang and apucher July 9, 2022 01:49
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #9034 (77953fa) into master (de16a0a) will decrease coverage by 1.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9034      +/-   ##
============================================
- Coverage     70.08%   68.85%   -1.24%     
+ Complexity     4957     4717     -240     
============================================
  Files          1827     1827              
  Lines         96064    96097      +33     
  Branches      14356    14360       +4     
============================================
- Hits          67327    66164    -1163     
- Misses        24092    25336    +1244     
+ Partials       4645     4597      -48     
Flag Coverage Δ
integration1 26.44% <ø> (+0.06%) ⬆️
integration2 ?
unittests1 66.88% <ø> (+<0.01%) ⬆️
unittests2 15.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...apache/pinot/common/helix/ExtraInstanceConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...t/core/plan/StreamingInstanceResponsePlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ore/operator/streaming/StreamingResponseUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ager/realtime/PeerSchemeSplitSegmentCommitter.java 0.00% <0.00%> (-100.00%) ⬇️
...ator/streaming/StreamingSelectionOnlyOperator.java 0.00% <0.00%> (-90.00%) ⬇️
...he/pinot/core/plan/StreamingSelectionPlanNode.java 0.00% <0.00%> (-88.89%) ⬇️
...che/pinot/common/auth/StaticTokenAuthProvider.java 0.00% <0.00%> (-87.50%) ⬇️
...roker/requesthandler/GrpcBrokerRequestHandler.java 0.00% <0.00%> (-87.24%) ⬇️
...re/query/reduce/SelectionOnlyStreamingReducer.java 0.00% <0.00%> (-80.96%) ⬇️
...ller/api/access/BasicAuthAccessControlFactory.java 0.00% <0.00%> (-80.00%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de16a0a...77953fa. Read the comment docs.

@xiangfu0 xiangfu0 merged commit bb0505f into apache:master Jul 9, 2022
@xiangfu0 xiangfu0 deleted the adding-auth-zk-basic-quickstart branch July 9, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants