Skip to content

Conversation

@walterddr
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #9046 (16cc896) into master (5625bea) will increase coverage by 0.05%.
The diff coverage is 56.41%.

❗ Current head 16cc896 differs from pull request most recent head 56cacfb. Consider uploading reports for the commit 56cacfb to get more accurate results

@@             Coverage Diff              @@
##             master    #9046      +/-   ##
============================================
+ Coverage     63.47%   63.53%   +0.05%     
- Complexity     4937     4943       +6     
============================================
  Files          1783     1783              
  Lines         94133    94165      +32     
  Branches      14139    14149      +10     
============================================
+ Hits          59754    59829      +75     
+ Misses        30124    30077      -47     
- Partials       4255     4259       +4     
Flag Coverage Δ
unittests1 66.89% <58.74%> (+0.05%) ⬆️
unittests2 15.38% <20.51%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pinot/broker/api/resources/PinotClientRequest.java 0.00% <0.00%> (ø)
...main/java/org/apache/pinot/client/PinotDriver.java 0.00% <0.00%> (ø)
.../java/org/apache/pinot/client/utils/Constants.java 0.00% <ø> (ø)
...ava/org/apache/pinot/client/utils/DriverUtils.java 4.49% <ø> (+0.09%) ⬆️
...t/controller/api/resources/PinotQueryResource.java 0.00% <0.00%> (ø)
...re/common/evaluators/DefaultJsonPathEvaluator.java 29.53% <0.00%> (ø)
...e/operator/dociditerators/MVScanDocIdIterator.java 70.37% <0.00%> (ø)
...e/operator/dociditerators/SVScanDocIdIterator.java 75.51% <0.00%> (ø)
...local/indexsegment/mutable/MutableSegmentImpl.java 54.34% <0.00%> (ø)
...readers/constant/ConstantMVForwardIndexReader.java 0.00% <ø> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5625bea...56cacfb. Read the comment docs.

@walterddr walterddr marked this pull request as ready for review July 12, 2022 21:33
Copy link
Contributor

@dongxiaoman dongxiaoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We mentioned 4.1.74.final but I do not see the value set in the changes. Should we set it somewhere?

@walterddr
Copy link
Contributor Author

We mentioned 4.1.74.final but I do not see the value set in the changes. Should we set it somewhere?

yeah netty.version is already bumped to use bom import in #8495. however I forgot to remove the 3.9.10.Final import. This PR removes that

@walterddr walterddr mentioned this pull request Jul 13, 2022
@walterddr walterddr merged commit aeaa26e into apache:master Jul 14, 2022
yuanbenson pushed a commit to yuanbenson/pinot that referenced this pull request Jul 20, 2022
* upgrade netty
* fix presto-pinot-driver dependency

Co-authored-by: Rong Rong <rongr@startree.ai>
@walterddr walterddr deleted the bump_netty branch December 6, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants