Skip to content

Conversation

@jackjlli
Copy link
Member

This PR removes jaxb specifications from Pinot pom files, as jaxb isn't directly used in Pinot codebase.

If there is dependency conflicts on this dependency in the future, i think the better approach is to resolve the conflict at best effort instead of directly specifying more and more versions to Pinot's pom files.

@jackjlli jackjlli requested a review from mayankshriv July 13, 2022 01:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #9050 (b2e032f) into master (63d53d5) will increase coverage by 6.57%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9050      +/-   ##
============================================
+ Coverage     63.49%   70.07%   +6.57%     
- Complexity     4716     4962     +246     
============================================
  Files          1783     1831      +48     
  Lines         94134    96270    +2136     
  Branches      14140    14390     +250     
============================================
+ Hits          59768    67457    +7689     
+ Misses        30110    24154    -5956     
- Partials       4256     4659     +403     
Flag Coverage Δ
integration1 26.52% <ø> (?)
integration2 24.62% <ø> (?)
unittests1 66.86% <ø> (+0.01%) ⬆️
unittests2 15.38% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...he/pinot/segment/local/segment/store/IndexKey.java 65.00% <0.00%> (-10.00%) ⬇️
...he/pinot/sql/parsers/parser/SqlInsertFromFile.java 43.75% <0.00%> (-6.25%) ⬇️
.../pinot/query/runtime/blocks/TransferableBlock.java 62.85% <0.00%> (-5.72%) ⬇️
.../impl/dictionary/BaseOffHeapMutableDictionary.java 81.33% <0.00%> (-3.34%) ⬇️
...inot/query/runtime/operator/TransformOperator.java 91.42% <0.00%> (-2.86%) ⬇️
...org/apache/pinot/core/common/ObjectSerDeUtils.java 89.63% <0.00%> (-0.82%) ⬇️
...rg/apache/pinot/sql/parsers/SqlNodeAndOptions.java 100.00% <0.00%> (ø)
...g/apache/pinot/sql/parsers/dml/InsertIntoFile.java 85.18% <0.00%> (ø)
.../java/org/apache/pinot/server/conf/ServerConf.java 82.75% <0.00%> (ø)
.../pinot/server/api/resources/MmapDebugResource.java 0.00% <0.00%> (ø)
... and 415 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d53d5...b2e032f. Read the comment docs.

Copy link
Contributor

@snleee snleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackjlli jackjlli merged commit 94597d3 into master Jul 13, 2022
@jackjlli jackjlli deleted the remove-jaxb branch July 13, 2022 18:54
yuanbenson pushed a commit to yuanbenson/pinot that referenced this pull request Jul 20, 2022
Co-authored-by: Jack Li(Analytics Engineering) <jlli@jlli-mn1.linkedin.biz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants