Skip to content

[Refactor] Batch(Offline) quickstarts to load all the example tables by default#9206

Merged
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:refactor-offline-quickstart
Aug 15, 2022
Merged

[Refactor] Batch(Offline) quickstarts to load all the example tables by default#9206
xiangfu0 merged 1 commit intoapache:masterfrom
xiangfu0:refactor-offline-quickstart

Conversation

@xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Aug 12, 2022

  • Always load all the batch tables by default.
  • Refactor offline table loading to QuickStartBase.
  • Each Batch quickstart just extend QuickStart class and write its own runSampleQueries method.
  • Adding one more query example for MultistageEngineQuickStart table join query.

Screenshot of default view and multi-stage engine quickstart sample:
image

@xiangfu0 xiangfu0 changed the title Refactor offline quickstarts to load all the tables by default Refactor batch(offline) quickstarts to load all the example tables by default Aug 12, 2022
@xiangfu0 xiangfu0 force-pushed the refactor-offline-quickstart branch 5 times, most recently from 2def42e to 6c0483a Compare August 12, 2022 21:39
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #9206 (b7ae5c3) into master (6ed17d2) will decrease coverage by 45.22%.
The diff coverage is 11.05%.

❗ Current head b7ae5c3 differs from pull request most recent head 3bc91c0. Consider uploading reports for the commit 3bc91c0 to get more accurate results

@@              Coverage Diff              @@
##             master    #9206       +/-   ##
=============================================
- Coverage     70.04%   24.81%   -45.23%     
+ Complexity     5003       53     -4950     
=============================================
  Files          1852     1842       -10     
  Lines         98760    98518      -242     
  Branches      15021    15005       -16     
=============================================
- Hits          69175    24449    -44726     
- Misses        24709    71630    +46921     
+ Partials       4876     2439     -2437     
Flag Coverage Δ
integration1 ?
integration2 24.81% <11.05%> (-0.04%) ⬇️
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mmon/assignment/InstanceAssignmentConfigUtils.java 12.19% <0.00%> (-3.19%) ⬇️
...he/pinot/common/assignment/InstancePartitions.java 40.00% <0.00%> (-1.18%) ⬇️
...ot/common/function/scalar/ArithmeticFunctions.java 16.66% <0.00%> (-52.90%) ⬇️
...ources/PinotInstanceAssignmentRestletResource.java 0.00% <0.00%> (-73.85%) ⬇️
...ntroller/helix/core/PinotHelixResourceManager.java 31.74% <0.00%> (-36.51%) ⬇️
...ntroller/helix/core/rebalance/TableRebalancer.java 0.00% <0.00%> (-78.31%) ⬇️
...local/indexsegment/mutable/MutableSegmentImpl.java 0.00% <ø> (-54.26%) ⬇️
...t/local/upsert/BaseTableUpsertMetadataManager.java 0.00% <0.00%> (ø)
...t/ConcurrentMapPartitionUpsertMetadataManager.java 0.00% <0.00%> (ø)
...psert/ConcurrentMapTableUpsertMetadataManager.java 0.00% <0.00%> (ø)
... and 1370 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 force-pushed the refactor-offline-quickstart branch from 6c0483a to 4b50cf4 Compare August 12, 2022 22:50
@xiangfu0 xiangfu0 force-pushed the refactor-offline-quickstart branch from 4b50cf4 to 54c123a Compare August 13, 2022 05:09
@xiangfu0 xiangfu0 changed the title Refactor batch(offline) quickstarts to load all the example tables by default [Refactor] Batch(Offline) quickstarts to load all the example tables by default Aug 15, 2022
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiangfu0 xiangfu0 force-pushed the refactor-offline-quickstart branch from 54c123a to 3bc91c0 Compare August 15, 2022 19:20
@xiangfu0 xiangfu0 merged commit a4e3adb into apache:master Aug 15, 2022
@xiangfu0 xiangfu0 deleted the refactor-offline-quickstart branch August 15, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants