[Feature] Support boolean literals equals and notEquals#9322
[Feature] Support boolean literals equals and notEquals#932261yao wants to merge 2 commits intoapache:masterfrom
Conversation
walterddr
left a comment
There was a problem hiding this comment.
This might not be the best way to support literal equations
let's first straighten out the target:
do we want to support this on transform or predicate
I think let's focus on transform functions.
in this case I think the missing piece is to add literal handling to binaryoperatortransformfunction on both side
do we want to do typed equal / not-equal check
let's only do non-typed check. b/c typed solution will be very complex: see
#8596
with the basic solution in we can focus on #8596 to actually make the literals typed.
I am not sure if I fully understand about your point on literal support for binaryTransform. Shouldn't two literal eval fall into scalar function by default? Or you meant expressions like SELECT <BOOL_EXPR> = TRUE ? this is already supported. I am not against using proposal #8596 depending on the priority. This PR is hacky and expensive. but I feel it is not worse than the implementation we already have right now. |
|
Discussed offline. Since this is not urgent, I'll do some refactoring first and then fix function registration with parameter types. |
Support boolean literal evaluation, eg. true = true, (true = true) != false