[multistage] hybrid routing support#9379
Merged
walterddr merged 8 commits intoapache:masterfrom Sep 11, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9379 +/- ##
============================================
- Coverage 69.76% 69.72% -0.04%
- Complexity 4787 5094 +307
============================================
Files 1885 1885
Lines 100293 100377 +84
Branches 15256 15275 +19
============================================
+ Hits 69966 69992 +26
- Misses 25381 25428 +47
- Partials 4946 4957 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 2 commits
September 11, 2022 11:32
walterddr
commented
Sep 11, 2022
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java
Outdated
Show resolved
Hide resolved
kishoreg
approved these changes
Sep 11, 2022
| repeated string instances = 1; | ||
| repeated string dataSources = 2; | ||
| map<string, SegmentList> instanceToSegmentList = 3; | ||
| map<string, SegmentMap> instanceToSegmentMap = 3; |
Member
There was a problem hiding this comment.
we can add another map<string,SegmentList> right? one for real time and one for offline.. thought your approah is more flexible if we add more tabletype
Contributor
Author
There was a problem hiding this comment.
yes this way it is more flexible
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java
Outdated
Show resolved
Hide resolved
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is preliminary support for hybrid routing on multistage engine. It copies so of the logics in the broker request side but not all. and only has basic testing.
Details
TODOs
this duplicates lots of logics out of BaseBrokerRequestHandler and also it doesn't do pruning well, so follow up