[multistage] Initial commit to support h2 testing#9406
Merged
siddharthteotia merged 3 commits intoapache:masterfrom Sep 16, 2022
Merged
[multistage] Initial commit to support h2 testing#9406siddharthteotia merged 3 commits intoapache:masterfrom
siddharthteotia merged 3 commits intoapache:masterfrom
Conversation
15 tasks
walterddr
force-pushed
the
pr_hook_up_h2_test
branch
2 times, most recently
from
e58d41b to
6b37689
Compare
added 2 commits
September 15, 2022 15:49
- adding H2 connection to load the same dataset - verify the final result against entire query resultset
- make it stable by sending ts into order by as well
walterddr
force-pushed
the
pr_hook_up_h2_test
branch
from
6b37689 to
7bd1182
Compare
walterddr
force-pushed
the
pr_hook_up_h2_test
branch
from
751ff9a to
925dbeb
Compare
Codecov Report
@@ Coverage Diff @@
## master #9406 +/- ##
============================================
- Coverage 69.77% 69.71% -0.06%
+ Complexity 5092 5089 -3
============================================
Files 1890 1890
Lines 100654 100677 +23
Branches 15327 15334 +7
============================================
- Hits 70231 70191 -40
- Misses 25445 25498 +53
- Partials 4978 4988 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| Object v1 = o1[index]; | ||
| Object v2 = o2[index]; | ||
| int result; | ||
| if (_useDoubleComparison[i]) { |
Contributor
There was a problem hiding this comment.
(nit) can avoid this if check by creating comparators upfront in the constructor
Contributor
There was a problem hiding this comment.
Actually nvm... it may then have to dereference the actual comparator anyway for dynamic dispatch. So probably not worth it
siddharthteotia
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.