Merged
Conversation
31 tasks
Codecov Report
@@ Coverage Diff @@
## master #9446 +/- ##
============================================
- Coverage 68.66% 63.62% -5.04%
+ Complexity 5136 4801 -335
============================================
Files 1916 1863 -53
Lines 102069 99764 -2305
Branches 15481 15218 -263
============================================
- Hits 70083 63479 -6604
- Misses 26980 31608 +4628
+ Partials 5006 4677 -329
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
force-pushed
the
pr_left_join
branch
from
6ed4163 to
b2bd612
Compare
siddharthteotia
approved these changes
Sep 29, 2022
walterddr
force-pushed
the
pr_left_join
branch
from
b2bd612 to
4936d21
Compare
Jackie-Jiang
approved these changes
Sep 29, 2022
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
* adding LEFT JOIN * also add test for null after and fix case when Co-authored-by: Rong Rong <rongr@startree.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support LEFT JOIN
CASE WHENexplicitlyThis PR doesn't handle implicit null value handle.