[multistage][hotfix] fix filter operator type convert#9450
Merged
walterddr merged 3 commits intoapache:masterfrom Sep 23, 2022
Merged
[multistage][hotfix] fix filter operator type convert#9450walterddr merged 3 commits intoapache:masterfrom
walterddr merged 3 commits intoapache:masterfrom
Conversation
walterddr
commented
Sep 22, 2022
...ry-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FilterOperand.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9450 +/- ##
=============================================
- Coverage 69.88% 34.99% -34.90%
+ Complexity 5099 185 -4914
=============================================
Files 1897 1902 +5
Lines 101320 101577 +257
Branches 15395 15423 +28
=============================================
- Hits 70807 35542 -35265
- Misses 25518 62992 +37474
+ Partials 4995 3043 -1952
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
siddharthteotia
approved these changes
Sep 22, 2022
Contributor
|
Let's add a test for = operator as well |
siddharthteotia
approved these changes
Sep 23, 2022
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
FilterOperand should use the non-cast result type, - fix the current behavior to always use the left-hand side for type casting - fixing type resulting in null issue Co-authored-by: Rong Rong <rongr@startree.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FilterOperand should use the non-cast result type, the current behavior to always use the left-hand side is wrong b/c sometimes there's a type cast on the left.