Skip to content

Refactor DataTable to pinot-common#9503

Merged
Jackie-Jiang merged 3 commits intoapache:masterfrom
xiangfu0:move-data-to-pinot-common
Oct 2, 2022
Merged

Refactor DataTable to pinot-common#9503
Jackie-Jiang merged 3 commits intoapache:masterfrom
xiangfu0:move-data-to-pinot-common

Conversation

@xiangfu0
Copy link
Contributor

Refactor DataTable and corresponding interfaces/implementations from pinot-core to pinot-common

@xiangfu0 xiangfu0 force-pushed the move-data-to-pinot-common branch from 53b30b7 to 504eae5 Compare September 30, 2022 18:08
@Jackie-Jiang Jackie-Jiang force-pushed the move-data-to-pinot-common branch 2 times, most recently from a269605 to 86c6267 Compare October 1, 2022 23:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Merging #9503 (74e2685) into master (15f2711) will increase coverage by 41.80%.
The diff coverage is 76.99%.

@@              Coverage Diff              @@
##             master    #9503       +/-   ##
=============================================
+ Coverage     28.15%   69.95%   +41.80%     
- Complexity       53     4793     +4740     
=============================================
  Files          1909     1924       +15     
  Lines        102046   102411      +365     
  Branches      15500    15539       +39     
=============================================
+ Hits          28734    71646    +42912     
+ Misses        70504    25706    -44798     
- Partials       2808     5059     +2251     
Flag Coverage Δ
integration1 26.05% <56.63%> (+0.07%) ⬆️
integration2 24.62% <45.13%> (+0.18%) ⬆️
unittests1 67.26% <74.54%> (?)
unittests2 15.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thandler/SingleConnectionBrokerRequestHandler.java 88.31% <ø> (ø)
...ache/pinot/common/datablock/ColumnarDataBlock.java 58.62% <ø> (ø)
.../apache/pinot/common/datablock/DataBlockUtils.java 66.66% <ø> (ø)
...g/apache/pinot/common/datablock/MetadataBlock.java 63.63% <ø> (ø)
...rg/apache/pinot/common/datablock/RowDataBlock.java 65.21% <ø> (ø)
...g/apache/pinot/common/datatable/BaseDataTable.java 78.94% <0.00%> (ø)
...a/org/apache/pinot/common/datatable/DataTable.java 92.06% <ø> (ø)
...apache/pinot/common/datatable/DataTableImplV3.java 94.70% <ø> (ø)
...apache/pinot/common/datatable/DataTableImplV4.java 71.42% <ø> (ø)
...ache/pinot/common/request/context/ThreadTimer.java 92.30% <ø> (ø)
... and 1392 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 force-pushed the move-data-to-pinot-common branch from 86c6267 to 85c1f60 Compare October 2, 2022 05:15
@xiangfu0 xiangfu0 force-pushed the move-data-to-pinot-common branch from 85c1f60 to 74e2685 Compare October 2, 2022 05:16
@Jackie-Jiang Jackie-Jiang merged commit 3f25471 into apache:master Oct 2, 2022
@xiangfu0 xiangfu0 deleted the move-data-to-pinot-common branch October 2, 2022 09:21
61yao pushed a commit to 61yao/pinot that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants