Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9559 +/- ##
============================================
+ Coverage 69.90% 69.97% +0.07%
- Complexity 4797 4872 +75
============================================
Files 1927 1929 +2
Lines 102729 102955 +226
Branches 15592 15624 +32
============================================
+ Hits 71811 72042 +231
+ Misses 25847 25823 -24
- Partials 5071 5090 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
force-pushed
the
pr_add_ssb_itcase
branch
from
822ca01 to
a3116c7
Compare
walterddr
force-pushed
the
pr_add_ssb_itcase
branch
from
021d073 to
5741667
Compare
walterddr
force-pushed
the
pr_add_ssb_itcase
branch
from
5741667 to
60d21db
Compare
jackjlli
approved these changes
Oct 10, 2022
|
|
||
| public static final String KEY_OF_MAX_INBOUND_QUERY_DATA_BLOCK_BYTES_SIZE = "pinot.query.runner.max.msg.size"; | ||
| public static final int DEFAULT_MAX_INBOUND_QUERY_DATA_BLOCK_BYTES_SIZE = 128 * 1024 * 1024; | ||
| public static final String KEY_OF_MAX_INBOUND_QUERY_DATA_BLOCK_SIZE_BYTES = "pinot.query.runner.max.msg.size.bytes"; |
Member
There was a problem hiding this comment.
I guess this config hasn't been in use yet, right?
Member
There was a problem hiding this comment.
Also, since this PR doesn't only modify the integration test, can we add some comments to the description section about this config change?
Contributor
Author
There was a problem hiding this comment.
this was a temporary fix. and it is no longer necessary to set it so large after #9485
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO