[cleanup] moving test sql to a yaml file for better readability#9580
Merged
Conversation
Contributor
walterddr
commented
Oct 12, 2022
- hard-coded string needs to follow checkstyle. also it cannot be directly copied.
- didn't use json b/c it doesn't support multiline as well as yaml
agavra
approved these changes
Oct 12, 2022
Contributor
agavra
left a comment
There was a problem hiding this comment.
😍 yessss! can we also do that for QueryRunnerTest and make this a generic thing we can use in lots of tests 🙏
Codecov Report
@@ Coverage Diff @@
## master #9580 +/- ##
============================================
+ Coverage 68.75% 68.79% +0.04%
- Complexity 4912 5253 +341
============================================
Files 1934 1934
Lines 103290 103290
Branches 15695 15695
============================================
+ Hits 71016 71061 +45
+ Misses 27187 27156 -31
+ Partials 5087 5073 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Oct 12, 2022
Contributor
Author
good idea. although there's more to improve in QueryRunnerTest for example
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.