Fixed flaky test in PluginManagerTest#9925
Merged
Jackie-Jiang merged 2 commits intoapache:masterfrom Dec 8, 2022
Merged
Conversation
ycliu28
changed the title
Jackie-Jiang
reviewed
Dec 8, 2022
|
|
||
| ArrayList<String> actualPluginNames = new ArrayList<>(); | ||
| ArrayList<String> actualPluginPaths = new ArrayList<>(); | ||
| HashSet<String> actualPluginNames = new HashSet<>(); |
Contributor
There was a problem hiding this comment.
Let's make it a string to string map and compare the map instead of comparing 2 sets
Contributor
Author
There was a problem hiding this comment.
Thanks for the advice, updated.
Jackie-Jiang
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugfixContext
Fixed the flaky test in 9924. The cause of it is that the test writes keys and values of a hashmap in to a list in a for loop, however, the order of the the map entry in a hashmap is non-deterministic.
Fix
Since the purpose of the test is not checking the order, it's more reasonable to write the keys and values in to hashsets than arraylists.