Validate HDGF v6+ chunk Length before narrowing to int#1075
Merged
pjfanning merged 1 commit intoMay 14, 2026
Conversation
Member
|
thanks - merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HDGF v6+
ChunkHeaderparser previously narrowed the unsigned 32-bitLengthfield using a plain(int)cast:Values larger than
Integer.MAX_VALUEsilently wrapped to negative numbers and could propagate into chunk offset arithmetic inChunkFactory.createChunk(...):This patch replaces the v6+
Lengthcast withMath.toIntExact(...), matching the existing v4/v5 handling already used in the same method.Identifier-style fields (
type,id,unknown1) intentionally retain their existing casts. Existing tests already verify that negative reinterpretation is part of the current behavior contract (for exampleheader.getId() == -1for0xFFFFFFFF).Tests
Added regression coverage for:
Lengthvalues (0x80000001)Integer.MAX_VALUEas a valid representable length