Handle oversized uint32 offsets in QuillContents descriptors#1077
Open
metsw24-max wants to merge 1 commit into
Open
Handle oversized uint32 offsets in QuillContents descriptors#1077metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuillContentsreads bit descriptorfrom/lenfields as uint32 values from Publisher.pubfiles, but previously narrowed them directly tointvia a plain cast before validation.A crafted descriptor with values larger than
Integer.MAX_VALUEcould therefore wrap to negative values and only fail later insideIOUtils.safelyClone(...)with a generic"Invalid offset\\length specified"error that lost the original unsigned value.This change validates the uint32 values before narrowing:
RecordFormatExceptioncarrying the original uint32 valueIOUtils.safelyAllocateCheck(...)before castingAdds regression tests that build minimal in-memory
.pubcontainers with crafted descriptor values and verify that oversized uint32 fields are rejected duringQuillContentsparsing.Tested:
TestQuillContentsOverflowregression tests