HSLF: reject oversized PersistPtr sheet offsets#1078
Open
metsw24-max wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden HSLF PersistPtr parsing against unsigned-to-signed integer truncation when reading sheet offsets from PersistPtrIncrementalBlock records.
Previously, PersistPtrHolder read 32-bit unsigned sheet offsets using
LittleEndian.getUInt(...)and narrowed them with a plain(int)cast. Values larger thanInteger.MAX_VALUEwrapped to negative offsets and were stored in_slideLocations.These wrapped offsets later flowed into
Record.buildRecordAtOffset(docstream, offset), where malformed inputs could cause the parser to read records from unintended positions in the document stream instead of rejecting the corrupted input cleanly.Changes
Math.toIntExact(...)when parsing PersistPtr sheet offsetsInteger.MAX_VALUETests
Added regression coverage in
TestPersistPtrHolder:testRejectsOversizedSheetOffsetArithmeticExceptiontestAcceptsMaxIntSheetOffset