Guard Ole10Native readUtf16 byte length against int overflow#1080
Open
jmestwa-coder wants to merge 1 commit into
Open
Guard Ole10Native readUtf16 byte length against int overflow#1080jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
pjfanning
reviewed
May 25, 2026
| RecordFormatException.class, | ||
| () -> new Ole10Native(data, 0) | ||
| ); | ||
| assertTrue(ex.getMessage().contains("Tried to allocate")); |
Member
There was a problem hiding this comment.
Use POITestCase assertContains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while fuzzing Ole10Native record parsing. readUtf16 reads a 32-bit char count and hands size * 2 to IOUtils.toByteArray; a count near 0x40000000 makes that product overflow to a negative int, which slips past the MAX_STRING_LENGTH cap so an oversized record surfaces a raw IllegalArgumentException from getFromUnicodeLE rather than the RecordFormatException the cap is meant to raise. Compute the byte count as size * 2L so the long overload applies the cap before narrowing.