Increase use of POITestCase assert methods and assertInstanceOf in tests#1083
Merged
pjfanning merged 1 commit intoMay 25, 2026
Merged
Conversation
Member
pjfanning
commented
May 25, 2026
pjfanning
commented
- Replace assertTrue(x instanceof Y) → assertInstanceOf(Y.class, x) (JUnit 5)
- Replace assertTrue(str.startsWith("lit")) → assertStartsWith(str, "lit") (POITestCase)
- Replace assertTrue(str.endsWith("lit")) → assertEndsWith(str, "lit") (POITestCase)
- Replace assertTrue(str.contains("lit")) → assertContains(str, "lit") (POITestCase)
- Replace assertFalse(str.contains("lit")) → assertNotContains(str, "lit") (POITestCase)
- Add missing assertInstanceOf/assertStartsWith/assertEndsWith/assertContains/assertNotContains imports
- Remove assertTrue/assertFalse imports from files where they are no longer used
- Sort all static and regular imports alphabetically (case-sensitive/ASCII order) in changed files
…s test suite
- Replace assertTrue(x instanceof Y) → assertInstanceOf(Y.class, x) (JUnit 5)
- Replace assertTrue(str.startsWith("lit")) → assertStartsWith(str, "lit") (POITestCase)
- Replace assertTrue(str.endsWith("lit")) → assertEndsWith(str, "lit") (POITestCase)
- Replace assertTrue(str.contains("lit")) → assertContains(str, "lit") (POITestCase)
- Replace assertFalse(str.contains("lit")) → assertNotContains(str, "lit") (POITestCase)
- Add missing assertInstanceOf/assertStartsWith/assertEndsWith/assertContains/assertNotContains imports
- Remove assertTrue/assertFalse imports from files where they are no longer used
- Sort all static and regular imports alphabetically (case-sensitive/ASCII order) in changed files
Agent-Logs-Url: https://github.com/pjfanning/poi/sessions/cdf60b8b-5a7b-47e7-8c54-4149d5fb6a02
Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.