Support mc:AlternateContent for XWPFRun.getPictureText().#1091
Merged
pjfanning merged 1 commit intoMay 27, 2026
Conversation
Modern Word versions create shapes inside blocks like these:
<mc:AlternateContent>
<mc:Choice Requires="wps">
<w:drawing>...</w:drawing>
</mc:Choice>
<mc:Fallback>
<w:pict>...</w:pict>
</mc:Fallback>
</mc:AlternateContent>
The existing implementation of XWPFRun.getPictureText() only searched
through drawing or pict items that are direct children of the run,
ignoring whatever was inside an <mc:AlternateContent> block. We add
code to include any <w:drawing> items inside these blocks.
We also modify XWPFParagraph.getPictureText() to insert line jumps
between different picture texts, following the mold from
XWPFRun.getPictureText().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern Word versions create shapes inside blocks like these:
The existing implementation of
XWPFRun.getPictureText()only searched through drawing or pict items that are direct children of the run, ignoring whatever was inside an<mc:AlternateContent>block. We add code to include any<w:drawing>items inside these blocks.We also modify
XWPFParagraph.getPictureText()to insert line jumps between different picture texts, following the mold fromXWPFRun.getPictureText().