use long for EmfPlusDrawDriverString glyph byte length#1098
Merged
pjfanning merged 1 commit intoJun 1, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmfPlusDrawDriverString.init reads a 32-bit glyph count from untrusted EMF+ bytes and allocates glyphCount2 bytes. The product is computed in int, so a count of 0x40000000 wraps negative and slips past the MAX_OBJECT_SIZE cap in IOUtils.toByteArray, surfacing a raw IllegalStateException instead of a RecordFormatException. Using glyphCount2L routes through the long toByteArray overload so the cap fires first.