HemfPlusPath: validate PointCount before array allocation#1103
Merged
Conversation
pjfanning
reviewed
Jun 2, 2026
| * PointCount is an untrusted 32-bit field, so cap it before it is used as an array length - | ||
| * consistent with e.g. {@code HemfPlusDraw.MAX_OBJECT_SIZE} and {@code HemfDraw.MAX_NUMBER_OF_POLYGONS}. | ||
| */ | ||
| private static final int MAX_POINTS = 1_000_000; |
Member
There was a problem hiding this comment.
make this configurable by adding a static setter, it's ok to default to 1m
Contributor
Author
There was a problem hiding this comment.
Updated as suggested.
jmestwa-coder
force-pushed
the
validate-path-pointcount
branch
from
3ee351e to
a61eaf7
Compare
pjfanning
reviewed
Jun 2, 2026
jmestwa-coder
force-pushed
the
validate-path-pointcount
branch
from
a61eaf7 to
f92d9fe
Compare
Member
|
@jmestwa-coder can you rebase this PR, there are merge conflicts |
Contributor
Author
|
rebase done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate
PointCountbefore allocating path arrays inEmfPlusPath.Problem
PointCountis read directly from EMF+ input.pathPointsandpointTypesarrays.Fix
PointCountusingIOUtils.safelyAllocateCheck(...).EmfPlusPathwith the existing allocation-safety pattern used elsewhere in HEMF parsing.