Apply allocation bounds checks to EmfPolyDraw and WmfCreateRegion#1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmfPolyDraw and WmfCreateRegion allocate arrays directly from count fields read from the input stream.
This change applies POI's existing allocation safety checks before the following count-driven allocations:
Point arrays in EmfPolyDraw
Scan object arrays in WmfCreateRegion
Invalid, excessively large, or negative counts are now rejected through POI's standard allocation validation path instead of attempting unchecked array allocations.
Tests
Added regression tests covering:
Integer.MAX_VALUE count in EmfPolyDraw
Negative count in WmfCreateRegion
These tests verify that malformed inputs are rejected before array allocation occurs.
Executed the automated unit tests:
./gradlew :poi-scratchpad:test -PjdkVersion=17