Rework getParagraph functions for XWPF#195
Closed
MariusVolkhart wants to merge 2 commits intoapache:trunkfrom
Closed
Rework getParagraph functions for XWPF#195MariusVolkhart wants to merge 2 commits intoapache:trunkfrom
MariusVolkhart wants to merge 2 commits intoapache:trunkfrom
Conversation
Make the documentation generic enough that subclasses don't need to supplement it with their own.
The previous implementation resulted in many allocations due to the repeated calls to getParagraphs(), which returns a new unmodifiable list every time. The implementation was also doing extra work with repeated index fetches. The new version brings this implementation in line with those found in XWPFTableCell, XWPFHeaderFooter, and XWPFAbstractFootnoteEndnote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementations all share an interface, so they don't need their own Javadoc, as the Javadoc is automatically inherited.
Also revise the implementation of
XWPFDocument#getParagraph(CTP)to be more performant.