Skip to content

poi-ooxml fix in module-info.java for java9+#237

Closed
Trobiun wants to merge 1 commit into
apache:trunkfrom
Trobiun:trunk
Closed

poi-ooxml fix in module-info.java for java9+#237
Trobiun wants to merge 1 commit into
apache:trunkfrom
Trobiun:trunk

Conversation

@Trobiun
Copy link
Copy Markdown

@Trobiun Trobiun commented Jul 6, 2021

This fixes problems when running image generated with jlink when using poi.
For example java.lang.IllegalAccessError: superclass access check failed: class org.apache.poi.openxml4j.util.ZipSecureFile (in module org.apache.poi.ooxml) cannot access class org.apache.commons.compress.archivers.zip.ZipFile (in module org.apache.commons.compress) because module org.apache.poi.ooxml does not read module org.apache.commons.compress

@asfgit asfgit closed this in 6c1bd28 Jul 6, 2021
@pjfanning
Copy link
Copy Markdown
Member

Thanks - merged with 6c1bd28

@pjfanning
Copy link
Copy Markdown
Member

@Trobiun I reverted one line from your module-info.java because it causes a build failure - 30c558f

/svn/poi/poi/src/main/java9/module-info.java:21: error: module not found: org.apache.commons.compress
    requires org.apache.commons.compress;

@pjfanning
Copy link
Copy Markdown
Member

I think I put the module-info setting in the right file now - d7d18d9

snsinahub pushed a commit to snsinahub-org/poi that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants