Correct Maximum Width Calculation of unmerged Cells#261
Closed
thoniTUB wants to merge 1 commit into
Closed
Conversation
…ximum width of unmerged cell
Member
|
Thanks - this is merged - will see about test coverage later |
Author
|
Alright, your welcome! |
Member
|
I'll probably need to revert this as it breaks a unit test |
Member
|
I modified the assertion on the test. Will still need to look into this more to see if this change is actually right. |
snsinahub
pushed a commit
to snsinahub-org/poi
that referenced
this pull request
Feb 28, 2023
…nks to thoniTUB. This closes apache#261 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894127 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I strumbled upon this code line, it did't cause a problem for me. However it could cause a problem if at some point merged cells are used, but the unmerge width is requested.