Skip to content

Avoid long literals ending with lowercase 'l'. These literals may be … #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arturobernalg wants to merge 1 commit into from
Closed

Avoid long literals ending with lowercase 'l'. These literals may be … #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion poi-scratchpad/src/main/java/org/apache/poi/hslf/record/Notes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
public final class Notes extends SheetContainer
{
private byte[] _header;
private static long _type = 1008l;
private static long _type = 1008L;

// Links to our more interesting children
private NotesAtom notesAtom;
Expand Down
2 changes: 1 addition & 1 deletion poi-scratchpad/src/main/java/org/apache/poi/hslf/record/NotesAtom.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
public final class NotesAtom extends RecordAtom {

private byte[] _header;
private static long _type = 1009l;
private static long _type = 1009L;

private int slideID;
private boolean followMasterObjects;
Expand Down
2 changes: 1 addition & 1 deletion poi-scratchpad/src/main/java/org/apache/poi/hslf/record/Slide.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
public final class Slide extends SheetContainer
{
private byte[] _header;
private static long _type = 1006l;
private static long _type = 1006L;

// Links to our more interesting children
private SlideAtom slideAtom;
Expand Down
2 changes: 1 addition & 1 deletion poi-scratchpad/src/main/java/org/apache/poi/hslf/record/SlideAtom.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public final class SlideAtom extends RecordAtom {
// private static final int MASTER_SLIDE_ID = 0x00000000;

private byte[] _header;
private static long _type = 1007l;
private static long _type = 1007L;

private int masterID;
private int notesID;
Expand Down
2 changes: 1 addition & 1 deletion poi-scratchpad/src/main/java/org/apache/poi/hslf/record/SlidePersistAtom.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public final class SlidePersistAtom extends RecordAtom {
//arbitrarily selected; may need to increase
private static final int MAX_RECORD_LENGTH = 32;

private static final long _type = 1011l;
private static final long _type = 1011L;
private static final int HAS_SHAPES_OTHER_THAN_PLACEHOLDERS = 4;

private static final int[] FLAGS_MASKS = { HAS_SHAPES_OTHER_THAN_PLACEHOLDERS };
Expand Down