Skip to content

Textruns not honouring highlight#409

Closed
gffloodg wants to merge 8 commits intoapache:trunkfrom
gffloodg:textruns-not-honoring-highlight
Closed

Textruns not honouring highlight#409
gffloodg wants to merge 8 commits intoapache:trunkfrom
gffloodg:textruns-not-honoring-highlight

Conversation

@gffloodg
Copy link
Copy Markdown

This PR adds support for getting/setting the highlight color in TextRuns. It also adds support for rendering of the same. As usual, appropriate tests also added.

* trunk: (22 commits)
  exclude sboms from source distro
  try ant for jdk 20 build due to policeman issues
  try ant for jdk 20 build due to policeman issues
  add sboms to bin/src dits
  [github-408] Increase performance of StylesTable.putStyle. Thanks to Jason Mirra. This closes apache#408
  java 20 build
  try to build sboms
  archive xmlbeans jdk 1.19 build
  archive xmlbeans sboms
  cyclonedx per module
  upgrade cyclonedx
  revert accidental change to multiply/divide
  upgrade mockito and byte-buddy
  slf4j 2.0.6
  [bug-66319] do not create HSSF patriarch to find comments (only use one that pre-exists)
  untidy hack for shared string counts that are higher than Integer.MAX_VALUE
  untidy hack for shared string counts that are higher than Integer.MAX_VALUE
  remove unnecessary short casts for getCellStyleAt
  try to speed up SXSSFCell getColumnIndex
  small optimisation on getCellStyle
  ...

# Conflicts:
#	poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFTableCell.java
Comment thread poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFTextRun.java Outdated
Comment thread poi/src/main/java/org/apache/poi/sl/usermodel/TextRun.java Outdated
Comment thread poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XSLFTextRun.java Outdated
@asfgit asfgit closed this in 37994bf Dec 28, 2022
@pjfanning
Copy link
Copy Markdown
Member

Thanks - merged

asfgit pushed a commit that referenced this pull request Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants