Skip to content

Expose the language tag associated with a run#86

Closed
glb wants to merge 1 commit into
apache:trunkfrom
glb:trunk
Closed

Expose the language tag associated with a run#86
glb wants to merge 1 commit into
apache:trunkfrom
glb:trunk

Conversation

@glb
Copy link
Copy Markdown

@glb glb commented Jan 4, 2018

It's useful to have the language tag associated with a run, for example if you want to propagate the language information to an HTML representation of the document for compliance with WCAG 2.0 3.1.2.

@asfgit
Copy link
Copy Markdown

asfgit commented Jan 4, 2018

Can one of the admins verify this patch?

Copy link
Copy Markdown
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glb - can you add a unit test?

@glb
Copy link
Copy Markdown
Author

glb commented Jan 4, 2018

Thanks @pjfanning -- I've added a unit test based on what I saw for similar methods. I also looked at TestDocument.docx which is referenced in the unit test suite and there weren't any language tags in that document, but have tested using documents I have with the language tags set and It Works For Me™.

@glb
Copy link
Copy Markdown
Author

glb commented Jan 4, 2018

Related -- are there any plans for a 3.18 release, and if so could this be cherry-picked back to that release? (I'd be happy to create the PR, but I didn't see an applicable branch.)

@pjfanning
Copy link
Copy Markdown
Member

@glb 4.0.0 is the next release but it is not scheduled yet

@asfgit asfgit closed this in d4df695 Jan 4, 2018
@glb
Copy link
Copy Markdown
Author

glb commented Jan 4, 2018

@pjfanning thank you!

Alain-Bearez pushed a commit to cuali/poi that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants