Skip to content

Conversation

@MonkeyCanCode
Copy link
Contributor

This PR fixed couple issues:

  1. Added missing licenses for couple more files
  2. Added missing workflow for polaris-synchronizer (also perform RAT check here)
  3. Added RAT check for mcp-server
  4. Removed publishToMavenLocal from workflows as we are not creating local maven repo for these tools projects
  5. Added paths for mcp-server during github action
  6. Updated .gitignore to exclude gradle wrapper checksum file
  7. Fixed broken polaris-synchronizer/gradlew
  8. Standardized license healers (matched to Apache Polaris...the existed ones are still valid)

@MonkeyCanCode MonkeyCanCode changed the title Added missing licenses/workflows and standardized license headers chore: add missing licenses/workflows and standardized license headers Nov 23, 2025
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @MonkeyCanCode !

It's a bit hard to review across all the tools. Would you mind splitting this PR by tool and concern?

- name: Build & Check
run: |
cd iceberg-catalog-migrator
./gradlew --rerun-tasks assemble ${{ env.ADDITIONAL_GRADLE_OPTS }} check publishToMavenLocal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional and part of the checks. Please do not remove.

@jbonofre jbonofre self-requested a review November 26, 2025 09:26
@jbonofre
Copy link
Member

Imho, LICENSE/NOTICE/DISCLAIMER are not correct in MCP server. I will create another PR to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants