Fixes and adds configurability to test_spark_sql_s3_with_privileges.py regtest #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis-bowen
requested review from
MonkeyCanCode,
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
travis-bowen
commented
Feb 27, 2025
|
|
||
| rotate_credentials = rotate_api.rotate_credentials(principal_name=principal_name) | ||
| return rotate_credentials | ||
| except ApiException as e: |
Contributor
Author
There was a problem hiding this comment.
removed since the catch block logic relies on rotate_client and rotate_client is only set in the try block so will generally be unset in the catch.
| Used to provide a path prefix between the port number and the standard polaris endpoint paths | ||
| :return: | ||
| """ | ||
| return os.getenv('POLARIS_PATH_PREFIX', '') |
Contributor
There was a problem hiding this comment.
It looks like this is expected to begin with / but to never end with it, while polaris_url_scheme and polaris_host are the opposite?
Contributor
Author
There was a problem hiding this comment.
Yeah - you're right - there's some inconsistencies.
Polaris_Host => no leading or trailing /
AWS_Bucket_Prefix = > No leading or trailing /
URL Schema => Updated to not have leading or trailing /
POLARIS_PATH_PREFIX => Now also updated to not have a leading or trailing / (the callsites that use it can determine whether to add those)
eric-maynard
approved these changes
Feb 27, 2025
Contributor
eric-maynard
left a comment
eric-maynard
left a comment
There was a problem hiding this comment.
LGTM, left one question about the new env vars
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
eric-maynard
approved these changes
Feb 28, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
gh-yzou
pushed a commit
to gh-yzou/polaris
that referenced
this pull request
Mar 6, 2025
…y regtest (apache#1060) * Test fix and ability to pass REG_TEST_TOKEN * Ability to configure bucket prefix * Add reg_test env var to docker compose * PR Comments * Add path prefix * Nit Updates * More updates * PR Feedback --------- Co-authored-by: Travis Bowen <travis.bowen@snowflake.com>
eric-maynard
pushed a commit
to eric-maynard/polaris
that referenced
this pull request
Mar 13, 2025
…y regtest (apache#1060) (apache#23) * Test fix and ability to pass REG_TEST_TOKEN * Ability to configure bucket prefix * Add reg_test env var to docker compose * PR Comments * Add path prefix * Nit Updates * More updates * PR Feedback --------- Co-authored-by: Travis Bowen <122238243+travis-bowen@users.noreply.github.com>
XJDKC
pushed a commit
to dennishuo/polaris
that referenced
this pull request
Mar 18, 2025
…y regtest (apache#1060) (apache#22) * Test fix and ability to pass REG_TEST_TOKEN * Ability to configure bucket prefix * Add reg_test env var to docker compose * PR Comments * Add path prefix * Nit Updates * More updates * PR Feedback --------- Co-authored-by: Travis Bowen <122238243+travis-bowen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Achieves the following:
1.) Fixes tests that currently fail
2.) Makes the REGTEST_ROOT_BEARER_TOKEN able to be passed in vs. instantiated from root, which can be used for instance to execute this test on long standing instances
3.) Allows an optional AWS_BUCKET_BASE_LOCATION_PREFIX to be passed in as well. This can also be useful for running against a long standing instance.
Here's the failed output on main.
And the success after this PR:
