Rename the sibling interfaces of PolarisMetastoreManager #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
force-pushed
the
persistence-refactor
branch
from
76ae9a2 to
4362396
Compare
flyrain
changed the title
dimas-b
reviewed
Apr 4, 2025
|
|
||
| /** Manage credentials for storage locations. */ | ||
| public interface PolarisCredentialVendor { | ||
| public interface CredentialVendorDao { |
Contributor
There was a problem hiding this comment.
I'm not sure how to interpret this rename (and relocation to a different package).
@flyrain : could you share an outline of the general ideas behind this refactoring on the dev ML? thx!
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactor without logic change.