Doc: Add breaking changes section for 1.1 release #2654
Conversation
singhpk234
requested review from
dimas-b,
eric-maynard,
flyrain and
jbonofre
flyrain
left a comment
flyrain
left a comment
There was a problem hiding this comment.
Thanks for working on it, @singhpk234 !
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
github-project-automation
bot
moved this from Done
to PRs In Progress
in Basic Kanban Board
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
Nice catch, @singhpk234 !
| - **Breaking changes** | ||
| - Helm chart: the default value of the `authentication.tokenBroker.secret.symmetricKey.secretKey` property has changed | ||
| from `symmetric.pem` to `symmetric.key`. | ||
| - For migrations from 1.0.x to 1.1.x, users using JDBC persistence and wanting to continue using v1 schema, must ensure that they, |
There was a problem hiding this comment.
What's the alternative to continue using v1 schema?
There was a problem hiding this comment.
One option is to migrate to v2 schema, which requires more than just the version table. We will need to write a tool for that per offline discussion with @singhpk234
There was a problem hiding this comment.
Apologies, I missed responding here:
I think there a couple of scenarios, for example
- if we simply move to v2 from v1 by adding the column in the entity table we will have to backfill the location without schema column
- if we started with v2 schema from day 1 we should be good or any realm created with v2 column starting should good too, but in the application layer for the optimization to correctly work there is no way to check this
Bottom line being my understanding is the optimized siblling check for migrated schema version might not be reliable, i was wondering if we should capture some additional metadata in a sense that is_migrated ? default value 0 but incase the schema table exists set this value to 1, now when we do the optimized sibbling check we will just say this is not applicable if the metastore is migrated across version, though this too has shortcommings to be honest for example v2 -> v3 migration should still work, would really appreciate your thoughts
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
|
Thanks a lot for adding this, @singhpk234 ! Thanks @dimas-b for the review. |
* Minio testcontainer: allow setting a specific region (apache#2664) ... to remove the need to derive it via the AWS-SDK default mechanism requiring a system property or environment variable. * fix(deps): update dependency org.apache.commons:commons-lang3 to v3.19.0 (apache#2665) * Doc: Add breaking changes section for 1.1 release (apache#2654) * fix(deps): update dependency com.h2database:h2 to v2.4.240 (apache#2668) * fix(auth): let ServiceFailureException bubble up for proper HTTP status mapping during auth (apache#2670) * fix(deps): update immutables to v2.11.4 (apache#2679) * fix(deps): update dependency com.diffplug.spotless:spotless-plugin-gradle to v8 (apache#2669) * chore(deps): update quay.io/keycloak/keycloak docker tag to v26.3.5 (apache#2681) * Last merged commit 2c0bf58 --------- Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Prashant Singh <35593236+singhpk234@users.noreply.github.com> Co-authored-by: Sushant Raikar <sushant.raikar+OSS@snowflake.com>
3 participants
About the change
Some users while upgrading from Polaris 1.0 -> 1.1 recently reported issues because of missing schema table, this would be happening because the schema version table is not created in v1 script as the course of that JDBCBasePersistenceImpl is failing and hence the whole metastore
Thank @flyrain for the deepdive : https://apache-polaris.slack.com/archives/C084XDM50CB/p1758368000877189
while there is already works on fixing this, while discussing with @flyrain they suggested having something in the release note would be really helpful which i agree, hence putting a docs pr.