-
Notifications
You must be signed in to change notification settings - Fork 334
Refactor: improve and clean up Dockerfiles #2957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
snazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement to image build performance! Thanks for this!
Some comments though, nothing dramatic.
|
@snazy all comments should be addressed now. Please take another look when you have a chance. |
snazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the ping slipped through..
+1!
* Refactor: improve and clean up Dockerfiles * Refactor: improve and clean up Dockerfiles * Refactor: improve and clean up Dockerfiles * Refactor: improve and clean up Dockerfiles * Refactor: improve and clean up Dockerfiles * Refactor: improve and clean up Dockerfiles
What changes were proposed in this pull request?
Why are the changes needed?
General cleanup and simplify existed dockerfiles
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested with various test suits we have around those docker files such as docker-compose instructions.
CHANGELOG.md
N/A