-
Notifications
You must be signed in to change notification settings - Fork 347
Helm chart: include configmap checksum in deployment annotations #3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think the |
|
Hi @cccs-cat001 I fully agree with the configmap checksum, but for the bootstrap job, we decided a while ago that it's not a good idea: Do you mind reshaping this PR to focus on the checksum only? For the bootstrap job, if you really think you need one, let's discuss a bit about it before. |
|
okay! Maybe my understanding of the bootstrap is lacking, it seemed to me more like a "one and done" type thing, not a "this could destroy you" thing 😅 I'll reconfigure the PR and I'll start a discussion in slack for this? As for the |
This reverts commit ff7a5f1.
…s to be no test to ensure there's only one annotation
I think the problem is also that there is currently no option to ignore an already-bootstrapped realm. So your job will fail if the realm is already bootstrapped, which means that your chart installation would fail as well.
You mean, the Helm version used by GitHub CI? No problems imho. |
1.) I added a checksum to the deployment so that any time the configmap changes the deployment restarts (so it can pick up the new configmap changes)
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)