Skip to content

Conversation

@cccs-cat001
Copy link
Contributor

@cccs-cat001 cccs-cat001 commented Nov 10, 2025

1.) I added a checksum to the deployment so that any time the configmap changes the deployment restarts (so it can pick up the new configmap changes)

  • If I'm going to be making more PRs I realize I need to figure out how to not have git showing commits from other changes 😅

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

@cccs-cat001
Copy link
Contributor Author

I think the helm test failures is because of the version... it deploys fine with helm 3.18.4 and the tests are using helm 3.16...

@adutra
Copy link
Contributor

adutra commented Nov 10, 2025

Hi @cccs-cat001 I fully agree with the configmap checksum, but for the bootstrap job, we decided a while ago that it's not a good idea:

#626 (comment)

Do you mind reshaping this PR to focus on the checksum only?

For the bootstrap job, if you really think you need one, let's discuss a bit about it before.

@cccs-cat001
Copy link
Contributor Author

okay! Maybe my understanding of the bootstrap is lacking, it seemed to me more like a "one and done" type thing, not a "this could destroy you" thing 😅 I'll reconfigure the PR and I'll start a discussion in slack for this?

As for the helm tests is there any issue with updating the workflow to use a newer version of helm?

@adutra
Copy link
Contributor

adutra commented Nov 10, 2025

okay! Maybe my understanding of the bootstrap is lacking, it seemed to me more like a "one and done" type thing, not a "this could destroy you" thing 😅 I'll reconfigure the PR and I'll start a discussion in slack for this?

I think the problem is also that there is currently no option to ignore an already-bootstrapped realm. So your job will fail if the realm is already bootstrapped, which means that your chart installation would fail as well.

As for the helm tests is there any issue with updating the workflow to use a newer version of helm?

You mean, the Helm version used by GitHub CI? No problems imho.

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 10, 2025
@adutra adutra merged commit 280dcaf into apache:main Nov 10, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 10, 2025
@adutra adutra changed the title Add some Helm Chart improvements Helm chart: include configmap checksum in deployment annotations Nov 10, 2025
MonkeyCanCode pushed a commit to MonkeyCanCode/polaris that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants