Skip to content

Core: resolveAll() must be called before reading resolution results #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

Core: resolveAll() must be called before reading resolution results #3064

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f5a713
Core: resolveAll() must be called before reading resolution results
flyrain Nov 17, 2025
0bfbb55
Resolve comments
flyrain Nov 19, 2025
1e2161d
Resolve comments
flyrain Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...src/main/java/org/apache/polaris/core/persistence/resolver/PolarisResolutionManifest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,14 @@ public class PolarisResolutionManifest implements PolarisResolutionManifestCatal
// Set when resolveAll is called
private ResolverStatus primaryResolverStatus = null;

private boolean isResolveAllSucceeded() {
diagnostics.checkNotNull(
primaryResolverStatus,
"resolver_not_run_before_access",
"resolveAll() must be called before reading resolution results");
return primaryResolverStatus.getStatus() == ResolverStatus.StatusEnum.SUCCESS;
}

public PolarisResolutionManifest(
PolarisDiagnostics diagnostics,
RealmContext realmContext,
Expand Down Expand Up @@ -256,7 +264,7 @@ public Set<PolarisBaseEntity> getAllActivatedPrincipalRoleEntities() {
}

private @Nullable ResolvedPolarisEntity getResolvedRootContainerEntity() {
if (primaryResolverStatus.getStatus() != ResolverStatus.StatusEnum.SUCCESS) {
if (!isResolveAllSucceeded()) {
return null;
}
ResolvedPolarisEntity resolvedEntity =
Expand Down Expand Up @@ -327,7 +335,7 @@ public PolarisResolvedPathWrapper getResolvedPath(Object key, boolean prependRoo
key,
pathLookup);

if (primaryResolverStatus.getStatus() != ResolverStatus.StatusEnum.SUCCESS) {
if (!isResolveAllSucceeded()) {
return null;
}
int index = pathLookup.get(key);
Expand Down Expand Up @@ -394,7 +402,7 @@ public PolarisResolvedPathWrapper getResolvedTopLevelEntity(
entityType,
addedTopLevelNames);

if (primaryResolverStatus.getStatus() != ResolverStatus.StatusEnum.SUCCESS) {
if (!isResolveAllSucceeded()) {
return null;
}

Expand Down