Fixes phantom event emission; Introduces StageCommitTableEvent #3073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @dimas-b Please let me know what you think with regards to your suggestion of needing a README/extended documentation. Also, should we add this to the CHANGELOG? That a new event type has been added? |
adnanhemani
force-pushed
the
ahemani/fix_phantom_events
branch
from
84626fc to
b4ce270
Compare
dimas-b
reviewed
Nov 19, 2025
| polarisEventListener.onAfterCommitTable( | ||
| new IcebergRestCatalogEvents.AfterCommitTableEvent( | ||
| catalogName, tableIdentifier, base, metadata)); | ||
| if (getMetaStoreManager() instanceof TransactionWorkspaceMetaStoreManager) { |
Contributor
There was a problem hiding this comment.
This if + instanceof looks concerning to me. I do believe the whole events design can and should be done in a way that processing logic does not require knowing specific types of pluggable components.
TransactionalWorkspaceMetaStoreManager in itself has API design concerns from my POV, so I believe this area of the code needs refactoring in general, so adding logic that depends on specific types is both risky and complicates future refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new event type
StageCommitTableEvent, which triggers only in the case of a transactional commit at the time the staged commit is generated (before the commit is actually applied). This allows us to reserve theAfterCommitTableEventsolely for when the commit has been successfully applied.In order to do this, I've made a slight addition to the
TransactionWorkspaceMetaStoreManagerclass to add the staging of events, mirroring exactly how we stage updates. Noting that there is no unit testing for this class, I've added this as well.Additionally, E2E testing for the events emissions in the CommitTransaction API has been added, looking both at the happy and sad paths.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)Closes #2990.