Skip to content

Conversation

@snazy
Copy link
Member

@snazy snazy commented Nov 20, 2025

The step was disabled in #3102 to pass CI and enable merging.

The step was disabled in apache#3102 to pass CI and enable merging.
@snazy snazy force-pushed the re-add-link-check-wf branch from 4d2682e to 19630ef Compare November 20, 2025 14:51
@snazy snazy marked this pull request as ready for review November 20, 2025 14:53
Copy link
Contributor

@pingtimeout pingtimeout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should re-enable those checks. They are flaky. And usually, people develop a habit of ignoring those checks all the time. I would rather have them run manually once in a while (possibly integrated to the release workflows) but that's it.

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 20, 2025
@snazy
Copy link
Member Author

snazy commented Nov 20, 2025

I don't think we should re-enable those checks. They are flaky. And usually, people develop a habit of ignoring those checks all the time. I would rather have them run manually once in a while (possibly integrated to the release workflows) but that's it.

Yea, I agree. Let's bring it up on the dev-ML.

@snazy snazy merged commit 132146d into apache:main Nov 20, 2025
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 20, 2025
@snazy snazy deleted the re-add-link-check-wf branch November 20, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants