Skip to content

Conversation

@snazy
Copy link
Member

@snazy snazy commented Nov 20, 2025

The "Check Markdown links" workflow is known to produce false failures, leading to #3097.

This change is intended to unblock PRs due to these false failures.

The "Check Markdown links" workflow is known to produce false failures, leading to apache#3097.

This change is intended to unblock PRs due to these false failures.
dimas-b
dimas-b previously approved these changes Nov 20, 2025
@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 20, 2025
@dimas-b
Copy link
Contributor

dimas-b commented Nov 20, 2025

+1

Markdown checks are very flaky and have been hindering PRs progress.

Recent example: https://github.com/apache/polaris/actions/runs/19534001072/job/55941993028?pr=2802

ERROR: 1 dead links found!
[✖] https://medium.com/@jitenderkmr/demystifying-snowflake-ids-a-unique-identifier-in-distributed-computing-72796a827c9d → Status: 403

^ that link works fine in a browser.

snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025
The step was disabled in apache#3102 to pass CI and enable merging.
@binarycat0
Copy link
Contributor

Will it help if extend set of ignorePatterns in .github/workflows/check-md-link-config.json?

{
  "ignorePatterns": [
    {
      "pattern": "https://medium.com/.*"
    },
    {
      "pattern": "^https?://localhost.*"
    },
    {
      "_comment": "mvnrepository blocks requests originating from GitHub Actions",
      "pattern": "https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-spark"
    }
  ]
}

@snazy
Copy link
Member Author

snazy commented Nov 20, 2025

Will it help if extend set of ignorePatterns in .github/workflows/check-md-link-config.json?

{
  "ignorePatterns": [
    {
      "pattern": "https://medium.com/.*"
    },
    {
      "pattern": "^https?://localhost.*"
    },
    {
      "_comment": "mvnrepository blocks requests originating from GitHub Actions",
      "pattern": "https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-spark"
    }
  ]
}

Maybe? ;)
Mind propsing on the dev-ML as a follow-up?

Copy link

@binarycat-dremio binarycat-dremio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pingtimeout pingtimeout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock CI

A better long-term solution might be to replace the trigger by a manual trigger (like the release workflows). That way we would still be able to check for dead links but we would not use our request quota unless we want it.

@snazy snazy merged commit c9d27dc into apache:main Nov 20, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 20, 2025
@snazy snazy deleted the md-link-check-optional branch November 20, 2025 14:50
snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025
The step was disabled in apache#3102 to pass CI and enable merging.
snazy added a commit that referenced this pull request Nov 20, 2025
The step was disabled in #3102 to pass CI and enable merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants