-
Notifications
You must be signed in to change notification settings - Fork 332
PRs: Remove markdown-links-check from required checks #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The "Check Markdown links" workflow is known to produce false failures, leading to apache#3097. This change is intended to unblock PRs due to these false failures.
|
+1 Markdown checks are very flaky and have been hindering PRs progress. Recent example: https://github.com/apache/polaris/actions/runs/19534001072/job/55941993028?pr=2802 ^ that link works fine in a browser. |
The step was disabled in apache#3102 to pass CI and enable merging.
|
Will it help if extend set of |
Maybe? ;) |
binarycat-dremio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pingtimeout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock CI
A better long-term solution might be to replace the trigger by a manual trigger (like the release workflows). That way we would still be able to check for dead links but we would not use our request quota unless we want it.
The step was disabled in apache#3102 to pass CI and enable merging.
The step was disabled in #3102 to pass CI and enable merging.
The "Check Markdown links" workflow is known to produce false failures, leading to #3097.
This change is intended to unblock PRs due to these false failures.